Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps.ffmpeg: Update libsrt to 1.5.2 #191

Merged
merged 1 commit into from
Jul 12, 2023
Merged

deps.ffmpeg: Update libsrt to 1.5.2 #191

merged 1 commit into from
Jul 12, 2023

Conversation

pkviet
Copy link
Member

@pkviet pkviet commented Jun 5, 2023 •
edited
Loading

Description

This updates srt to 1.5.2. This has a commit which fixes a bug [1,2] with rendezvous mode.

[1] Haivision/srt#2664
[2] Haivision/srt@1cffd2f

Motivation and Context

Fix bug and keep up-to-date deps.
Companion PR in obs-studio [3].

[3] obsproject/obs-studio#9026

How Has This Been Tested?

Builds fine locally on wsl.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@pkviet pkviet marked this pull request as draft June 5, 2023 18:03
@pkviet pkviet mentioned this pull request Jun 5, 2023
Merged
6 tasks
@pkviet pkviet changed the title deps.ffmpeg: Update srt to 1.5.2rc2 deps.ffmpeg: Update srt to 1.5.2 Jun 29, 2023
@pkviet
Copy link
Member Author

pkviet commented Jun 29, 2023

Update
PR undrafted since libsrt 1.5.2 has been released. I've updated and tested the PR accordingly.

@pkviet pkviet marked this pull request as ready for review June 29, 2023 17:57
RytoEX
RytoEX requested changes Jun 30, 2023
View reviewed changes
deps.ffmpeg/60-srt.zsh Outdated Show resolved Hide resolved
@pkviet
Copy link
Member Author

pkviet commented Jun 30, 2023

i've fixed the mishap and retested srt to YouTube and local srt-live-transmit; worked fine.

RytoEX
RytoEX requested changes Jul 6, 2023
View reviewed changes
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message and PR title nit:

  • use "libsrt" instead of "srt", in line with commit history

@pkviet pkviet changed the title deps.ffmpeg: Update srt to 1.5.2 deps.ffmpeg: Update libsrt to 1.5.2 Jul 7, 2023
@pkviet
deps.ffmpeg: Update libsrt to 1.5.2
fbc16ed 
This updates libsrt to 1.5.2. This has a commit which fixes a bug with
rendezvous mode [1,2] in obs.

[1] Haivision/srt#2664
[2] Haivision/srt@1cffd2f
@pkviet
Copy link
Member Author

pkviet commented Jul 7, 2023

Commit message and PR title nit:

  • use "libsrt" instead of "srt", in line with commit history

fixed.
Tested that caller / listener / rendezvous mode are all working.

RytoEX
RytoEX approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. If you've done testing, this should be fine.

@RytoEX RytoEX merged commit d05f3e6 into obsproject:master Jul 12, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RytoEX RytoEX RytoEX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pkviet @RytoEX