Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains four commits:
deps.qt: Restore Patch function for Windows Qt script
The Patch function was left out of a previous rewrite.
deps.qt: Backport patch for CVE-2023-43114
The CVE only affects Windows.
Fixed in 6.5.4 and 6.6.0.
https://www.qt.io/blog/security-update-regarding-cve-2023-43114
https://codereview.qt-project.org/c/qt/qtbase/+/504321
http://bugreports.qt.io/browse/QTBUG-116773
deps.qt: Backport patch for QTBUG-117779
Fix a bug on Windows where child windows would move with the parent
window and also resize to their minimum size.
Fixed in 6.5.4, 6.6.1, and 6.7.
https://bugreports.qt.io/browse/QTBUG-117779
https://bugreports.qt.io/browse/QTBUG-118118
https://bugreports.qt.io/browse/QTBUG-118217
deps.qt: Backport patch for QTBUG-118117
Fix a bug on Windows that caused taskbar icon overlays to be reset by Qt
if previously set via native Windows API calls.
Fixed in 6.5.4, 6.6.1, and 6.7.
https://bugreports.qt.io/browse/QTBUG-118117
Motivation and Context
Qt 6.5.4 is Commercial LTS only. Don't want these bugs in our release.
How Has This Been Tested?
On Windows 11, I built Qt locally with these patches and built OBS Studio against that version of Qt. I verified that QTBUG-117779 and QTBUG-118117 were no longer present.
Types of changes
Checklist: