Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PipeWire capture fails to compile on FreeBSD #4951

Closed
yurivict opened this issue Jun 28, 2021 · 7 comments · Fixed by #7992
Closed

PipeWire capture fails to compile on FreeBSD #4951

yurivict opened this issue Jun 28, 2021 · 7 comments · Fixed by #7992
Labels
Other OS (*nix) Other Unix-like systems that are not officially supported (e.g. OpenBSD)

Comments

@yurivict
Copy link

Operating System Info

Other

Other OS

FreeBSD

OBS Studio Version

27.0.1

OBS Studio Version (Other)

13

OBS Studio Log URL

n/a

OBS Studio Crash Log URL

No response

Expected Behavior

linux-capture should compile as before.

Current Behavior

The linux-capture plugin worked on FreeBSD in 26.1.2 but in 27.0.1 it doesn't compile any more due to this linux-specific line: https://github.com/obsproject/obs-studio/blob/master/plugins/linux-capture/pipewire.c#L30

Users complain: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256862

Steps to Reproduce

Anything else we should know?

No response

@yurivict yurivict changed the title [refression] The linux-capture plugin stopped working on FreeBSD in 27.0.1 [refression] The linux-capture plugin fails to compile on FreeBSD in 27.0.1 Jun 28, 2021
@WizardCM
Copy link
Member

This is a new feature introduced in #4287. You're likely missing libgles2-mesa or libgles2-mesa-dev (or similar) when building, or missing it as a dependency for users.

@yurivict yurivict changed the title [refression] The linux-capture plugin fails to compile on FreeBSD in 27.0.1 [regression] The linux-capture plugin fails to compile on FreeBSD in 27.0.1 Jun 28, 2021
@VodBox VodBox reopened this Jun 28, 2021
@VodBox
Copy link
Member

VodBox commented Jun 28, 2021

I'll admit that I don't have much knowledge of FreeBSD, so I may be asking dumb questions.

I see that you've applied a patch on the FreeBSD port that just disables PipeWire using CMake. Is Wayland/PipeWire capture something that a FreeBSD user would be using or need, and that's just a temporary measure to make sure the rest of the plugin builds? Or is that what you'd consider an acceptable solution?

@VodBox VodBox added the Other OS (*nix) Other Unix-like systems that are not officially supported (e.g. OpenBSD) label Jun 28, 2021
@VodBox VodBox changed the title [regression] The linux-capture plugin fails to compile on FreeBSD in 27.0.1 PipeWire capture fails to compile on FreeBSD Jun 28, 2021
@yurivict
Copy link
Author

I see that you've applied a patch on the FreeBSD port that just disables PipeWire using CMake. Is Wayland/PipeWire capture something that a FreeBSD user would be using or need, and that's just a temporary measure to make sure the rest of the plugin builds? Or is that what you'd consider an acceptable solution?

I don't have much knowledge about Wayland. Particularly, I am not sure of its purpose or benefits to users. I don't think Wayland is currently used at all on FreeBSD. So this is a measure to make the capture plugin work on FreeBSD for the time being. The linux/dma-buf.h header is installed only by graphics/drm-current-kmod and graphics/drm-fbsd13-kmod when the SOURCE option is set to ON, which is OFF by default.

@playaspec
Copy link

Both Wayland and Pipewire are indeed used by some FreeBSD users. Wayland is the *NIX successor to X11, and Pipewire is the soon to be successor to Jack/Pulseaudio. I think what caused here was missing tests to see which subsystems your platform is using, and only including and compiling the appropriate components.

@Fenrirthviti
Copy link
Member

Is this issue still present, and is this something that would need to be fixed in OBS, or is it an environment issue?

As a reminder, nobody on the OBS team uses or has any knowledge about FreeBSD, so we will be unable to submit any fixes necessary, and rely on the FreeBSD community to provide them.

@Fenrirthviti
Copy link
Member

No response, closing. If this is still an issue, a PR with a fix would be welcome, but as mentioned nobody on the team is able to debug FreeBSD issues.

@Fenrirthviti Fenrirthviti closed this as not planned Won't fix, can't repro, duplicate, stale Jan 27, 2023
@kkartaltepe kkartaltepe reopened this Feb 5, 2023
@kkartaltepe
Copy link
Collaborator

Re-opened as there is a pending fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Other OS (*nix) Other Unix-like systems that are not officially supported (e.g. OpenBSD)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants