Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDS client: use "sourcename" option during "read()" (for MSEED format data) #1431

Merged
merged 1 commit into from
May 31, 2016

Conversation

megies
Copy link
Member

@megies megies commented May 31, 2016

Just a minor improvement, in case of non-expected data stored in files. During reading data, only look at records with seed pattern of interest using "sourcename" option in _read_mseed().

during reading data, only look at records with seed pattern of interest
using "sourcename" option in _read_mseed()
@megies megies added this to the 1.0.2 milestone May 31, 2016
@megies megies merged commit 608fe71 into maintenance_1.0.x May 31, 2016
@megies megies deleted the sds_sourcename branch May 31, 2016 12:58
@sbonaime
Copy link
Contributor

could you also add "sourcename" option in add_data_to_archive to avoid #1398 ?

@megies
Copy link
Member Author

megies commented May 31, 2016

could you also add "sourcename" option in add_data_to_archive to avoid #1398 ?

That's not concerning this PR but rather #1413.

Also, "sourcename" is only an option for reading MiniSEED.
Also also, the routines to add data to archive in #1413 are already writing data trace by trace to the expected file name, splitting data by expected file name..

Please review before adding requests.. (and in the right ticket) 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants