rel_calib_stack: fix bug when using non-default windowing overlap fraction #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for windowing overlap fraction
megies
added
.signal
|
CC @jwassermann @mbdb since you're using this.. |
In signal.calibration.rel_calib_stack there's a bug in spectrum scaling when using a non-default window overlap fraction (default is 0.5, i.e. 50% overlap). This bug likely has been in there for ages. The reason was that computation of how many windows will be computed did not account for used overlap. Fix is trivial, as the FFT helper routine returns all individual FFTs, we can just look at the shape of the FFT result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
signal.calibration.rel_calib_stackthere's a bug in spectrum scaling when using a non-default window overlap fraction (default is0.5, i.e. 50% overlap). This bug has been in there from the very beginning. So, all calculations ever made using this function with non-default overlap fraction are wrong.Here's a plot from the regression test I added, showing how spectra are offset for different choices of window overlap fraction:
The reason was that computation of how many windows will be computed did not account for used overlap. Fix is trivial, as the FFT helper routine returns all individual FFTs, we can just look at the shape of the FFT result.
I'll add a regression test and a fix.