Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rel_calib_stack: fix bug when using non-default windowing overlap fraction #1821

Merged
merged 2 commits into from
Jun 21, 2017
Merged

rel_calib_stack: fix bug when using non-default windowing overlap fraction #1821

merged 2 commits into from
Jun 21, 2017

Commits on Jun 21, 2017

  1. calibration: add failing test that shows problem with non-default choice 

    for windowing overlap fraction
    @megies
    megies committed Jun 21, 2017
    Configuration menu
    Copy the full SHA
    6ac0291 View commit details
    Browse the repository at this point in the history

  2. fix bug in signal.calibration.rel_calib_stack 

    In signal.calibration.rel_calib_stack there's a bug in spectrum scaling
when using a non-default window overlap fraction (default is 0.5, i.e.
50% overlap). This bug likely has been in there for ages.

The reason was that computation of how many windows will be computed did
not account for used overlap. Fix is trivial, as the FFT helper routine
returns all individual FFTs, we can just look at the shape of the FFT
result.
    @megies
    megies committed Jun 21, 2017
    Configuration menu
    Copy the full SHA
    d0cf54f View commit details
    Browse the repository at this point in the history