-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CircleCI 2.0 compatibility #2257
Conversation
Okay, ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick, but looks good to me and seems to work in CircleCI
name: install dependencies | ||
command: | | ||
conda create -n test-env | ||
source activate test-env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conda activate ...
is what they propose nowadays
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I was not even aware that they unified linux with windows in terms of that. Thanks!
Well, it seems that |
This reverts commit 5461080.
Ah OK, yeah, then just use the old style, I guess. Whatever works.. |
Cool! Thanks for this :-) |
What does this PR do?
Changes the config of CircleCI to be compatible with CircleCI 2.0. The CircleCI 1.0 was EOLed on 31st of Agust, 2018.
https://circleci.com/blog/sunsetting-1-0/
Why was it initiated? Any relevant Issues?
Nope.
PR Checklist
master
for new features,maintenance_...
for bug fixesJust remove the space in the following string after the + sign: "+ DOCS"
(e.g.
clients.fdsn,clients.arclink
) after the colon in the following magic string: "+TESTS:"(you can also add "ALL" to just simply run all tests across all modules)
CHANGELOG.txt
.CONTRIBUTORS.txt
.