New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove taup.tau.remove-create_taup_model() which is no longer used #2272

Merged
merged 2 commits into from Dec 6, 2018

Conversation

Projects
None yet
2 participants
@seisman
Contributor

seisman commented Dec 4, 2018

What does this PR do?

Remove a function taup.tau.remove-create_taup_model().

Why was it initiated? Any relevant Issues?

This function is never used in the source codes. It is also not tested at all. The function calls a method TauPCreate.main, which doesn't exists. The function is replaced by taup.taup_create.build_taup_model().

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just remove the space in the following string after the + sign: "+DOCS"
  • If any network modules should be tested for the PR, add them as a comma separated list
    (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:"
    (you can also add "ALL" to just simply run all tests across all modules)
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
@megies

This comment has been minimized.

Member

megies commented Dec 6, 2018

Interesting.. I can't even find evidence that this code ever worked in any release version.

@megies

This comment has been minimized.

Member

megies commented Dec 6, 2018

Can you please do this PR against master though? This PR won't fix anything maintenance-wise, but changes the exception that will be raised when trying to use this function from an AttributeError to an ImportError, potentially. Also please remove the now unused import of TauPCreate.

@megies

This comment has been minimized.

Member

megies commented Dec 6, 2018

Can you please do this PR against master though?

I can cherry-pick your commit on master if it's too much hassle for you..

Thanks for the PR :)

@seisman seisman changed the base branch from maintenance_1.1.x to master Dec 6, 2018

@seisman seisman force-pushed the remove-create_taup_model branch from 4cc42db to a6e6519 Dec 6, 2018

@seisman seisman force-pushed the remove-create_taup_model branch from a6e6519 to 667ee09 Dec 6, 2018

@seisman

This comment has been minimized.

Contributor

seisman commented Dec 6, 2018

@megies I've changed the base branch to master and removed the unused import of TauPCreate.

@seisman seisman requested a review from megies Dec 6, 2018

@megies megies added this to the 1.2.0 milestone Dec 6, 2018

@megies megies added the .taup label Dec 6, 2018

@megies

megies approved these changes Dec 6, 2018

Looks good, thanks a lot again!

@megies megies merged commit 0932202 into master Dec 6, 2018

0 of 5 checks passed

ci/circleci Your tests failed on CircleCI
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
docs-buildbot Build succeeded, but there are warnings/errors:
Details
docker-testbot docker testbot results not available yet

@megies megies deleted the remove-create_taup_model branch Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment