taup: fix colors in ray path plots #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@okling would be nice if you could review this change |
QuLogic
reviewed
Oct 10, 2019
megies
force-pushed
the
fix_taup_rayplots
branch
from
55d79b9
to
d79f460
Compare
QuLogic
reviewed
Oct 23, 2019
megies
force-pushed
the
fix_taup_rayplots
branch
from
d79f460
to
6ea41e1
Compare
properly cycle through our fixed colors
…explicitly requested phases (if the same list of phases is requested)
package versions: matplotlib 2.2.2 basemap 1.1.0 basemap-data-hires 1.1.0
|
CI passes, gonna do a final rebase and merge |
megies
force-pushed
the
fix_taup_rayplots
branch
from
0e3abf6
to
edf2060
Compare
megies
added a commit
that referenced
this pull request
Apr 8, 2022
11 tasks
megies
added a commit
that referenced
this pull request
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix colors in ray path plots and properly cycle through our fixed colors. Plots are gonna change colors, so might need updating image test, I guess..
Why was it initiated? Any relevant Issues?
Fixes #2470
PR Checklist
masterfor new features,maintenance_...for bug fixesJust remove the space in the following string after the + sign: "+ DOCS"
(e.g.
clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:"(you can also add "ALL" to just simply run all tests across all modules)
CHANGELOG.txt.CONTRIBUTORS.txt.+DOCS