Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cycling through colors in ray path plots, now also fixes cartesia… #3041

Merged
merged 1 commit into from Apr 12, 2022

Conversation

megies
Copy link
Member

@megies megies commented Apr 8, 2022

What does this PR do?

Fixes #2470.. again! Now also for cartesian plots..

Why was it initiated? Any relevant Issues?

See #2470 and #2478

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just add the "build_docs" tag to this PR.
    Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
    Please post a link to the relevant piece of documentation.
  • If all tests including network modules (e.g. clients.fdsn) should be tested for the PR,
    just add the "test_network" tag to this PR.
  • All tests still pass.
  • Any new features or fixed regressions are covered via new tests.
  • Any new or changed features are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
  • If the changes affect any plotting functions you have checked that the plots
    from all the CI builds look correct. Add the "upload_plots" tag so that plotting
    outputs are attached as artifacts.
  • Add the "ready for review" tag when you are ready for the PR to be reviewed.

@megies megies added upload_images Signals CI to attach all produced images as github artifacts. build_docs Docs will be automatically built and deployed in github actions on pushes to the PR labels Apr 8, 2022
@megies
Copy link
Member Author

megies commented Apr 8, 2022

@jrekoske can you check if this works for you and maybe also check if other plots still work when docs build is done and can be seen at https://docs.obspy.org/pr ?

@jrekoske
Copy link
Contributor

jrekoske commented Apr 8, 2022

@megies Looks good thanks!

@megies megies merged commit 7a7f248 into maintenance_1.3.x Apr 12, 2022
@megies megies deleted the fix_tau_color_cartesian branch April 12, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build_docs Docs will be automatically built and deployed in github actions on pushes to the PR upload_images Signals CI to attach all produced images as github artifacts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants