Update taper max_percentage

[zackspica]

if not set to None, will not respond to other param like max_length.

What does this PR do?

Please fill in

Why was it initiated? Any relevant Issues?

Please fill in

PR Checklist

• Correct base branch selected? master for new features, maintenance_... for bug fixes
• This PR is not directly related to an existing issue (which has no PR yet).
• If the PR is making changes to documentation, docs pages can be built automatically.
  Just remove the space in the following string after the + sign: "+ DOCS"
• If any network modules should be tested for the PR, add them as a comma separated list
  (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:"
  (you can also add "ALL" to just simply run all tests across all modules)
• All tests still pass.
• Any new features or fixed regressions are be covered via new tests.
• Any new or changed features have are fully documented.
• Significant changes have been added to CHANGELOG.txt .
• First time contributors have added your name to CONTRIBUTORS.txt .

[megies]

I do not understand the motivation for this change, can you elaborate please?

[zackspica]

When you apply the taper with only arg max_length=xx you have the following error:

…

--------------------------------------------------------------------------- TypeError Traceback (most recent call last) <ipython-input-3-69767a402736> in <module>

----> 1 tr.taper(max_length=3) TypeError: taper() missing 1 required positional argument: 'max_percentage' So one has to add both arguments (max_percentage=None, max_length=xx) which I found confusing but I realize there is probably a reason for it... Ƶ.

On Tue, Oct 29, 2019 at 5:50 PM Tobias Megies ***@***.***> wrote: I do not understand the motivation for this change, can you elaborate please? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2492?email_source=notifications&email_token=AAOA33KKIJ2YIBY7V27C2QTQQ72M5A5CNFSM4JGFAGU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECPWMUY#issuecomment-547317331>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOA33NAMGGZQ7TEZUZGILDQQ72M5ANCNFSM4JGFAGUQ> .

[megies]

Yes, because max_percentage is required. This is partly due to historic reasons, and requiring the percentage option over an absolute length option as mandatory is a matter of taste, I guess. With this proposed change, using .taper() with default arguments and no customization would basically do nothing to the data. I don't think that's a better solution compared to forcing input by users.

Also this is a non-problem, just call it with taper(max_percentage=None, max_length=...)