-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unify logging configuration #2720
Conversation
62e372d
to
b8ed66b
Compare
b8ed66b
to
4e4676f
Compare
This PR is ready for review. I also added the possibility to specify a second Closes #2625. |
Changes in |
Yes, these changes just deal with a DeprecationWarning of matplotlib. Are only related, because both warnings and logs show when running obspy-runtests. |
I just took again a look on this PR and I though about something that new. Why only deprecation since it's targeting master? |
Thanks for having a look. I am all for fast depreciation, but I think most people favor a slower pace with depreciations only for mayor versions. IMHO this is ready for merging. |
268fee6
to
2a0f723
Compare
2a0f723
to
6088dc1
Compare
6088dc1
to
19f8ac3
Compare
19f8ac3
to
6719a7d
Compare
look OK if all tests 🟢 |
This PR tries to unify the logging configuration.
All calls to
logging.basicConfig
inside the library are deleted and someloglevel
keywords are removed. Logging should be configured in the user's code. A simplelogging.basicConfig()
is often good enough.I added the NullHandler to the obspy's root loggerLogging is only'obspy'
so that by default no logging is emmited.configureddisplayed forobspy-runtests -v
.WIP: If this PR is endorsed I would further refine it.PR Checklist
master
for new features,maintenance_...
for bug fixesJust remove the space in the following string after the + sign: "+ DOCS"
(e.g.
clients.fdsn,clients.arclink
) after the colon in the following magic string: "+TESTS:"(you can also add "ALL" to just simply run all tests across all modules)
CHANGELOG.txt
.CONTRIBUTORS.txt
.