Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add py3.11 to github actions workflows #3205

Merged
merged 25 commits into from Nov 8, 2022
Merged

add py3.11 to github actions workflows #3205

merged 25 commits into from Nov 8, 2022

Conversation

trichter
Copy link
Member

@trichter trichter commented Nov 3, 2022

What does this PR do?

Add python 3.11 to test matrix and to wheels builder workflow.

Why was it initiated? Any relevant Issues?

Fixes #3196

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just add the "build_docs" tag to this PR.
    Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
    Please post a link to the relevant piece of documentation.
  • If all tests including network modules (e.g. clients.fdsn) should be tested for the PR,
    just add the "test_network" tag to this PR.
  • All tests still pass.
  • Any new features or fixed regressions are covered via new tests.
  • Any new or changed features are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
  • If the changes affect any plotting functions you have checked that the plots
    from all the CI builds look correct. Add the "upload_plots" tag so that plotting
    outputs are attached as artifacts.
  • Add the "ready for review" tag when you are ready for the PR to be reviewed.

@megies
Copy link
Member

megies commented Nov 3, 2022

working on the warnings

@trichter trichter added the test_network tell github actions to also run network tests for this PR label Nov 3, 2022
@trichter trichter mentioned this pull request Nov 4, 2022
11 tasks
@trichter trichter added this to the 1.4.0 milestone Nov 4, 2022
@megies
Copy link
Member

megies commented Nov 4, 2022

@trichter i rewrote the functionality from xdrlib (didnt commit or push yet).. but I'll first ask over at cpython if we can just copy paste that file, that would be easiest and safest

@megies
Copy link
Member

megies commented Nov 8, 2022

Ah whatever.. @trichter I just pushed my rewrite of what was used. Tests pass but not all code in ah is covered by tests.. whelp. Can't be asked to start a research project about whether we can include that code from cpython codebase or not

@trichter
Copy link
Member Author

trichter commented Nov 8, 2022

Ah whatever.. @trichter I just pushed my rewrite of what was used. Tests pass but not all code in ah is covered by tests.. whelp. Can't be asked to start a research project about whether we can include that code from cpython codebase or not

I think it is absolutely no problem to copy Python's xdrlib.py and the test file over to ObsPy. We can just include the PSF license in the doc string of the two files. It is GPL compatible and thus also compatible with LGPL.

@megies
Copy link
Member

megies commented Nov 8, 2022

I think it is absolutely no problem to copy Python's xdrlib.py and the test file over to ObsPy. We can just include the PSF license in the doc string of the two files. It is GPL compatible and thus also compatible with LGPL.

Sure go ahead if you feel like it 👍

@trichter
Copy link
Member Author

trichter commented Nov 8, 2022

Sure go ahead if you feel like it +1

Like so? We need to handle a merge conflict however.

@trichter
Copy link
Member Author

trichter commented Nov 8, 2022

@megies I think it is ready. Later we can check the wheel for py3.11 win again. Its not working because the wheel for lxml is still missing.

@megies megies merged commit 274223d into master Nov 8, 2022
@megies megies deleted the py3.11 branch November 8, 2022 16:11
@ThomasLecocq ThomasLecocq mentioned this pull request Aug 8, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test_network tell github actions to also run network tests for this PR test_wheels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.11 tests & packages
2 participants