New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance CI workflow triggers #3206
Conversation
Hmm.. so docs building will only be triggered on commit pushes again, after the label was added?
Nice! Wanted to propose that earlier, but then didn't to not add more workload |
Both ways have disadvantages. At master, the docs bulding is altogether canceled if another label is added and if the worker is still running. This of course can be enhanced. But still, we cannot trigger the workflow only when the build_docs label is added. It is only possible to trigger the workflow for all labels and only after that skip the job if a label different form build_docs was applied. The checks tabs only displays the latest run of a workflow and would display |
OK, maybe I can add that back for the docs label. |
That I don't understand.. labels can only be on PRs, no?
Yea, I guess you cannot prevent docs build on master to get interrupted on master pushes, but I dont think its a problem is it? Docs building is really fast these days, and we don't push to master that often and at least over night (/ quieter hours) CI will be able to build new docs uninterrupted by pushes.
Hmm yea.. thats quite unfortunate
Sure, we can go back to that, no problem with that on my end, given the above caveats |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change as you like, maybe PR template needs to be adjusted though, to point out how docs builds can be triggered (or not)
What does this PR do?
I tried to improve the workflow triggers. The goal was to trigger the corresponding workflows when specific labels are added using the "labeled" pull_request event. This was impractical, because workflows were triggered for all new applied labels. Later, jobs can be canceled for inappropriate labels, but then the checks tab will only show these skipped jobs.
Therefore, I removed this feature again for the docs_building workflow.
Secondly, I added a trigger for the wheel building; these are now triggered in PRs with the test_wheels label instead of using specific branch names.
This PR is branched from #3205.PR Checklist
master
for new features,maintenance_...
for bug fixesJust add the "build_docs" tag to this PR.
Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
Please post a link to the relevant piece of documentation.
clients.fdsn
) should be tested for the PR,just add the "test_network" tag to this PR.
CHANGELOG.txt
.CONTRIBUTORS.txt
.from all the CI builds look correct. Add the "upload_plots" tag so that plotting
outputs are attached as artifacts.