-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebrand IRIS -> EarthScope #3448
Conversation
this is mostly just docs/docstrings, leave "obspy.clients.iris" module naming as is
@chad-earthscope I went through our codebase and tried to most appropriately replace "IRIS" wording, even though some of the web services still go under the "IRISWS" label and also I'm not sure if/where it might be more appropriate to use "SAGE" instead of "EarthScope". Feel free to comment and check out the docs build for this PR when CI is done (https://docs.obspy.org/pr/). I would really rather keep the module structure/Pathon file naming of |
ObsPy is many students' first introduction to community data at IRIS-now-EarthScope; I think that |
We could just do a wildcard import at the top of a newly created earthscope module no? from obspy.clients.iris import * In that case the modules should behave identically. |
These are "only" the IRIS-custom web services, which actually are still branded "IRISWS" upstream.
We'd have to mirror the internal module structure (which admittedly is quite simple). I really doubt the gain from that though, considering the confusion it will create simultaneously. |
I'll merge this for now @chad-earthscope, but let me know if you have any comments |
Thanks @megies, very appreciated change that I've had in the back of my mind, but have no time to deal with. "EarthScope" is probably best label for now ("SAGE" is our funders facility name, which will change next year). I agree with all your changes with one exception: "IRISWS Federator" should be "EarthScope Federator". While there is |
What does this PR do?
Rename IRIS -> EarthScope, this is mostly just docs/docstrings, leave "obspy.clients.iris" module naming as is.
Why was it initiated? Any relevant Issues?
Fixes #3336
PR Checklist
master
for new features,maintenance_...
for bug fixesno_ci
label can be added to skip CI buildsJust add the
build_docs
tag to this PR.Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
Please post a link to the relevant piece of documentation.
clients.fdsn
) should be tested for the PR,just add the
test_network
tag to this PR.CHANGELOG.txt
.CONTRIBUTORS.txt
.from all the CI builds look correct. Add the "upload_plots" tag so that plotting
outputs are attached as artifacts.
CODEOWNERS
with your github handleready for review
label when you are ready for the PR to be reviewed.