Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebrand IRIS -> EarthScope pt. 2 #3456

Merged
merged 6 commits into from
May 22, 2024
Merged

rebrand IRIS -> EarthScope pt. 2 #3456

merged 6 commits into from
May 22, 2024

Conversation

megies
Copy link
Member

@megies megies commented May 21, 2024

What does this PR do?

This is a follow up for #3448 following #3448 (comment)

This changes some more docstring wordings to EarthScope and will show deprecation warnings when using 'IRIS' short URL to initialize an FDSN client and 'iris-federator' when initializing an federator client.

Why was it initiated? Any relevant Issues?

see #3448

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • While the PR is still work-in-progress, the no_ci label can be added to skip CI builds
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just add the build_docs tag to this PR.
    Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
    Please post a link to the relevant piece of documentation.
  • If all tests including network modules (e.g. clients.fdsn) should be tested for the PR,
    just add the test_network tag to this PR.
  • All tests still pass.
  • Any new features or fixed regressions are covered via new tests.
  • Any new or changed features are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
  • If the changes affect any plotting functions you have checked that the plots
    from all the CI builds look correct. Add the "upload_plots" tag so that plotting
    outputs are attached as artifacts.
  • New modules, add the module to CODEOWNERS with your github handle
  • Add the yellow ready for review label when you are ready for the PR to be reviewed.

@megies megies added .clients.fdsn test_network tell github actions to also run network tests for this PR build_docs Docs will be automatically built and deployed in github actions on pushes to the PR labels May 21, 2024
@megies megies added this to the 1.5.0 milestone May 21, 2024
@megies megies added the ready for review PRs that are ready to be reviewed to get marked ready to merge label May 21, 2024
@megies
Copy link
Member Author

megies commented May 22, 2024

I just realized Python is not even showing DeprecationWarnings by default.. what madness is this

Gonna change these warnings to ObsPyDeprecationWarning

Python has been hiding DeprecationWarnings by default for ages now, for
whatever silly reason
@megies
Copy link
Member Author

megies commented May 22, 2024

Screenshot from 2024-05-22 12-54-13

@megies
Copy link
Member Author

megies commented May 22, 2024

@chad-earthscope did some more changes, will merge this, let me know if there's anything else, but I think this is everything now besides renaming obspy.clients.iris module, which isn't planned as it's to tedious / dangerous to break codes

@megies megies merged commit b5ebebd into master May 22, 2024
30 of 35 checks passed
@megies megies deleted the iris_rename branch May 22, 2024 13:35
@chad-earthscope
Copy link
Contributor

Looks good to me, thanks @megies!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build_docs Docs will be automatically built and deployed in github actions on pushes to the PR .clients.fdsn ready for review PRs that are ready to be reviewed to get marked ready to merge test_network tell github actions to also run network tests for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants