Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Station improvements (based on master) #750

Merged
merged 47 commits into from
Mar 27, 2014
Merged

Station improvements (based on master) #750

merged 47 commits into from
Mar 27, 2014

Conversation

megies
Copy link
Member

@megies megies commented Mar 3, 2014

Starting to add some plots to Station object classes..

  • Response: Bode plot
  • Channel: Bode plot (take Nyquist as upper bound)
  • Station: maybe with a kwarg switch (e.g. type=.. one of "response", "location", "both")
    • plot station location on global map
    • Bode plot with all channels (either all channels in one set of plots or subplots for each channel or separate figures for each channel)
  • Network/Inventory: Bode plot
  • Network/Inventory: Location plot like with Catalog
  • Add image tests
  • Add example plots / images in API docs
  • bode plot: only annotate sensitivity if the chosen output units match the overall sensitivity units?
  • annotate correct amplification units (e.g. "count/ m/s"; could be parsed from start/end stage but has to take chosen output units into account)
  • wrap bode plots in a class in imaging (to avoid code duplication, enhance custom reusability, ..)?
  • use time stamp to restrict matching channels
  • include plots in gallery
  • include option to plot PAZ-stage-only as alternative for comparison
  • tests for new methods added to station objects (select(), is_active())
  • __len__ attribute for Inventory/Network/Station?
  • Inventory.count(level="network", count_empty=True) method?

Comments?

- more intuitive for users to be able to specify sampling rate +
  frequency step (i.e. min/max/step of frequencies) in plot (rather than
  t_samp and nfft)
- make it able to provide two axes for the plotting instead of making a
  new figure (will be used in plotting multiple channels in
  Station/Network/Inventory)
@megies megies mentioned this pull request Mar 3, 2014
5 tasks
makes it simpler and clearer, for a map location plot it is probably
easier to nest the station into a network and use that for plotting
makes no sense in many cases because responses for channels might be
pretty different and matching a range of stages across channels
usually won't make much sense.
@megies
Copy link
Member Author

megies commented Mar 3, 2014

For the Inventory/Network map plots we should probably refactor the Catalog.plot() routine into a helper function in imaging and reuse it.

For station I think we should actually leave away the location plot option.

With being able to specify wildcarded station/channel/location codes it might actually make sense to have a bode plot attached to Network/Inventory..

Also, all plotting routines attached to Network/Inventory need a time option for selecting a certain "snapshot" in time.

@megies
Copy link
Member Author

megies commented Mar 7, 2014

- adjust axes for ticklabels
- adjust basemap region (width/height) to match figure aspect ratio
  (avoids squishy axes with large empty spaces around it)
- Inventory/Network:
  - .plot(): basemap plot (like with Catalog/Event)
  - .plot_response(): bode plots
- Station/Channel/Response:
  - .plot(): bode plots
- correct label handling
- add option for legend
- some minor tweaks
- some updates due to new legend option
- use matplotlib 1.3.1 and basemap 1.0.7 for all images
- correct checking of Python version number on py2.6
- force sorted order of plot legend on py3 (random dict order)
@megies
Copy link
Member Author

megies commented Mar 15, 2014

@krischer.. ready to merge I think. What do you think? The rest in the todo list up top is kind of optional/extra stuff..

coding in python3 (sets are randomly ordered in py3)
@megies
Copy link
Member Author

megies commented Mar 27, 2014

The main things were done, merging.

megies added a commit that referenced this pull request Mar 27, 2014
Station improvements (based on master)
@megies megies merged commit 2b83c38 into master Mar 27, 2014
@megies megies deleted the station_plots_master branch March 27, 2014 21:59
@QuLogic QuLogic modified the milestone: 0.10.0 Jul 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.core.inventory issues related to our Inventory functionality enhancement feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants