Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin removed in future version ? #23

Closed
AntoineDavidSupersoniks opened this issue Dec 29, 2020 · 9 comments · Fixed by #24
Closed

Plugin removed in future version ? #23

AntoineDavidSupersoniks opened this issue Dec 29, 2020 · 9 comments · Fixed by #24

Comments

@AntoineDavidSupersoniks

Hi,

With certbot 1.10.1 i've this warning :

Plugin legacy name certbot-plugin-gandi:dns may be removed in a future version. Please use dns instead.

What is DNS plugin ?

Cordialy

@bourgeoa
Copy link

bourgeoa commented Jan 7, 2021

I suppose this relates to the following :
There will be no future developments on this API, as we are merging to our new REST api endpoint, which is documented at https://api.gandi.net/docs/livedns/

@alexzorin
Copy link
Contributor

alexzorin commented Jan 26, 2021

The deprecation warning refers to the "prefix" part of the plugin entrypoint when you pass it on the Certbot CLI. More information at certbot/certbot#8131.

Currently, with the prefix:

--certbot-plugin-gandi:dns-credentials

Afterwards, without the prefix:

--dns-credentials

Unfortunately in this case of this project, using the generic dns name doesn't mesh too great with the deprecation of the prefix.

cc @obynio, just so you are aware of the potential future issue.

@AntoineDavidSupersoniks
Copy link
Author

Currently I am using the following instructions and I have no problems apart from this anxiety-provoking warning

--authenticator certbot-plugin-gandi:dns --certbot-plugin-gandi:dns-credentials /root/.secrets/gandi.ini

@JulienPalard
Copy link
Contributor

Looks like it works without the prefix:

--authenticator dns --dns-credentials /etc/gandi.ini

... hum, doing a PR to explain that and migrate to a better name.

@JulienPalard
Copy link
Contributor

JulienPalard commented Feb 12, 2021

In #24 I propose we use --authenticator dns-gandi and --dns-gandi-credentials, while keeping compat with the prefixed notation during a transition period (say up to cerbot completly drop it).

@AntoineDavidSupersoniks
Copy link
Author

Awesome !

@obynio
Copy link
Owner

obynio commented Feb 16, 2021

Hello, a new version was release to add these changes

@AntoineDavidSupersoniks
Copy link
Author

AntoineDavidSupersoniks commented Feb 17, 2021

HI with a pip upgrade i don't have the new release :(

pip3 install certbot-plugin-gandi --upgrade

i'v the following error :

root@65df9fa35a70:~# certbot certonly --authenticator dns-gandi --dns-gandi-credentials /root/.secrets/certbot/gandi-supersoniks.ini -d decoflorale.com
Saving debug log to /var/log/letsencrypt/letsencrypt.log
Plugins selected: Authenticator dns-gandi, Installer None
Requesting a certificate for decoflorale.com
Performing the following challenges:
dns-01 challenge for decoflorale.com
Cleaning up challenges
Missing property in credentials configuration file /root/.secrets/certbot/gandi-supersoniks.ini:
 * Property "dns_gandi_api_key" not found (should be API key for Gandi account).

file : gandi-supersoniks.ini:

# live dns v5 api key
certbot_plugin_gandi:dns_api_key=xxxxxxxxxxxxxxxxxxxxxxxxxxxx

# new ???
dns_gandi_api_key:dns_api_key=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

# optional organization id, remove it if not used
# certbot_plugin_gandi:dns_sharing_id=SHARINGID

@obynio
Copy link
Owner

obynio commented Feb 26, 2021

@AntoineDavidSupersoniks please take a look at this #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants