Skip to content

Commit

Permalink
Fix 804, encoding user code (#818)
Browse files Browse the repository at this point in the history
* Fix #804 encoding issue

* Minor refactoring of boolean should_send_logs logic


Negate bool

* Change incorrect boolean logic

* Update minikube status check (#846)

* Update logic to check whether minikube is already running.

* Updated except to check for CalledProcessError.

* Merge branch 'master' into minikube-run-start
  • Loading branch information
OlafSzmidt authored and CelineBoudier committed Oct 24, 2018
1 parent 7daf127 commit 7755047
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions aimmo-game/service.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,7 @@ def _find_avatar_id_from_query(self, session_id, query_string):

def _send_logs(self, player_id_to_workers):
def should_send_logs(logs):
LOGGER.info("should_send_logs: " + str(logs))

return logs is not None and logs != ''
return bool(logs)

socket_session_id_to_player_id_copy = self._socket_session_id_to_player_id.copy()
for sid, player_id in socket_session_id_to_player_id_copy.iteritems():
Expand Down

0 comments on commit 7755047

Please sign in to comment.