Fix 804, encoding user code

[OlafSzmidt]

Fixes the issue described in #804. We can let users use non ASCII (ie. UTF-8 encoded unicode) text fine imo. It was just a cast to str that wasn't being encoded in the same format as the rest.

I also refactored the boolean logic. None evaluates to false and so does an empty string :)

Everything I said might be wrong in k8s mode though. I don't know what to expect in terms of string encoding on each of the pods.

---

This change is 

[riaJha97]

Ran it in k8s mode, looks fine.

Reviewed 1 of 1 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @OlafSzmidt)

[riaJha97]

Not sure the boolean logic refactoring worked though, just had a look at the build and there are failing tests.

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @OlafSzmidt)

[riaJha97]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @OlafSzmidt)

---

aimmo-game/service.py, line 104 at r1 (raw file):

    def _send_logs(self, player_id_to_workers):
        def should_send_logs(logs):
            return not bool(logs)

shouldn't this be without the not?

[OlafSzmidt]

Are you sure the tests are related? Everything I push lately seem to be failing until I restart the build enough times. I'll have a look at which ones later though

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @OlafSzmidt)

---

aimmo-game/service.py, line 104 at r1 (raw file):

Previously, riaJha97 wrote…

shouldn't this be without the not?

Yeah, you're right. I'll make the change in a few

[riaJha97]

Two of the failing tests were test_no_logs_not_emitted and test_empty_logs_not_emitted. I assume they would work once you change the boolean condition.
We have been having issues with the build, but there haven't been any failing tests in these cases and you just have to restart.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @riaJha97)

[mrniket]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @riaJha97)

---

aimmo-game/service.py, line 104 at r1 (raw file):

Previously, OlafSzmidt (Olaf Szmidt) wrote…

Yeah, you're right. I'll make the change in a few

@OlafSzmidt any updates?

[OlafSzmidt]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @riaJha97)

---

aimmo-game/service.py, line 104 at r1 (raw file):

Previously, mrniket (Niket Shah) wrote…

@OlafSzmidt any updates?

Done.

[riaJha97]

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @riaJha97 and @mrniket)

[OlafSzmidt]

There seems to be an issue with the snyk manifests?

[TheseusGrey]

Ignore them for now. There seems to be an issue with them, they are not blocking pull requests so you can still merge once this has been sorted

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @riaJha97 and @mrniket)

[mrniket]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @riaJha97)

[mrniket]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @riaJha97)

[mrniket]

Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @riaJha97)

[OlafSzmidt]

Dismissed @riaJha97 from a discussion.
Reviewable status: complete! all files reviewed, all discussions resolved

[OlafSzmidt]

I don't want to merge this as I don't have access to deployment servers etc. If someone could please do it ;)