Remove pykube dependency #715
Conversation
There was a problem hiding this comment.
Reviewed 2 of 6 files at r1.
Reviewable status: 2 of 6 files reviewed, 1 unresolved discussion (waiting on @NiallEgan)
aimmo-game/setup.py, line 15 at r1 (raw file):
'requests', 'six', 'pykube',
Add kubernetes here?
There was a problem hiding this comment.
Reviewable status: 1 of 6 files reviewed, 1 unresolved discussion (waiting on @OlafSzmidt and @NiallEgan)
aimmo-game/setup.py, line 15 at r1 (raw file):
Previously, OlafSzmidt (Olaf Szmidt) wrote…
Add kubernetes here?
Done.
There was a problem hiding this comment.
What about pykube in the setup of root?
Also, in root/aimmo/setup.py?
And aimmo_runner module?
aimmo-game-worker requirements?
Reviewed 3 of 6 files at r1, 2 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
If you could also tag the issues on codeclimate as valid, invalid, etc.
The ones where the code is similar between separate pods we can state is invalid because they don't run within the same container anyway so we can't refactor that.
Reviewable status:
There was a problem hiding this comment.
aimmo-game-worker/requirements.txt as well
Reviewable status: 6 of 10 files reviewed, all discussions resolved (waiting on @NiallEgan)
There was a problem hiding this comment.
Reviewed 5 of 5 files at r3.
Reviewable status:
Fixes #703 . Has been tested on dev .
This change is