Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

K8S mode doesn't recreate games properly #718

Closed
OlafSzmidt opened this issue Aug 10, 2018 · 0 comments
Closed

K8S mode doesn't recreate games properly #718

OlafSzmidt opened this issue Aug 10, 2018 · 0 comments
Assignees

Comments

@OlafSzmidt
Copy link
Contributor

OlafSzmidt commented Aug 10, 2018

Describe the bug
The games cannot be recreated sometimes in k8s mode after the most recent PR (see additional context below). Not sure what this is dependant on just yet.

When recreate_game() is called, it tries to delegate the function call to delete_game() at line 80. Then _remove_resources is called for that particular game_id with the string Service.

The function is then retrieved from the dict at the top of _remove_resources and called at line 302. That returns the following:

delete_namespaced_service() takes 3 positional arguments but 4 were given.

To Reproduce
Not sure. Needs investigating. Happens on my branch worker_owners right now but I'm 99% sure this is an issue on master too.

Checkout commit dd1827c if you want to test this out but it seems dependant on the previous state of the database.

Expected behavior
To recreate games fine without error.

Screenshots
screen shot 2018-08-10 at 15 58 32

Desktop (please complete the following information):

  • OS: [e.g. Ubuntu] MacOS
  • Browser [e.g. chrome, safari] Canary Google
  • Version [e.g. 22] 70.0.3517.0
  • Minikube 0.25.2

Additional context
Introduced through #715.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants