Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade k8s requirements #719

Merged
merged 1 commit into from
Aug 13, 2018
Merged

upgrade k8s requirements #719

merged 1 commit into from
Aug 13, 2018

Conversation

NiallEgan
Copy link
Contributor

@NiallEgan NiallEgan commented Aug 13, 2018

According to the k8s python-client changelog (https://github.com/kubernetes-client/python/blob/master/CHANGELOG.md), delete_namespaced_service takes a body parameter in version 6.0. This fixes #718. Has been tested on dev.


This change is Reviewable

Copy link
Contributor

@mrniket mrniket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @NiallEgan)

a discussion (no related file):
Have we checked if this affects anything on a production environment?


Copy link
Contributor Author

@NiallEgan NiallEgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @NiallEgan)

a discussion (no related file):

Previously, mrniket (Niket Shah) wrote…

Have we checked if this affects anything on a production environment?

I've tested it on the dev server, but not on staging or production


Copy link
Contributor

@mrniket mrniket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

a discussion (no related file):

Previously, NiallEgan (Niall Egan) wrote…

I've tested it on the dev server, but not on staging or production

Sounds good :)


@NiallEgan NiallEgan merged commit ef723ac into master Aug 13, 2018
@NiallEgan NiallEgan deleted the update_k8s_client branch August 13, 2018 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants