This repository has been archived by the owner on Aug 25, 2023. It is now read-only.
YACHT-1133: deleted partition_id from dataset/list restore #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radkomateusz
previously approved these changes
Dec 4, 2018
|
Do not merge, needs to fix tests |
Fixed unit tests.
radkomateusz
reviewed
Dec 5, 2018
| @@ -111,24 +111,6 @@ def test_should_not_create_restore_items_for_deleted_backups(self): | |||
| # then | |||
| self.assertEqual(generated_restore_items, [[restore_item]]) | |||
|
|
|||
| def test_should_create_restore_item_for_partition( | |||
There was a problem hiding this comment.
I would left this tests, but edit what it expects.
We still use partitionId in source table, only we don't specified them for target. (it is how it was done in BackupCreator class - I believe we should do the same for restore also).
| @@ -196,15 +178,13 @@ def __prepare_tables_which_should_be_returned_by_max_partition_days_query(): | |||
| project_id=PROJECT_TO_RESTORE, | |||
| dataset_id=DATASET_TO_RESTORE, | |||
| table_id='tbl1', | |||
| date=datetime(2017, 12, 6), | |||
| partition_id='20171206' | |||
There was a problem hiding this comment.
after change, your tests doesn't generate partitions in datastore.
In my opinion it should, we still want to test how our application works for partitioned table.
radkomateusz
approved these changes
Dec 6, 2018
|
I deployed this commit on dev, then created copy jobs that restore partitioned table and it looks like it works without any errors. |
Pull Request Test Coverage Report for Build 928
💛 - Coveralls |
przemyslaw-jasinski
approved these changes
Dec 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential solution. Need to be tested on dev.