Skip to content
This repository has been archived by the owner on Aug 25, 2023. It is now read-only.

YACHT-1133: deleted partition_id from dataset/list restore #101

Merged
merged 3 commits into from
Dec 10, 2018
Merged

YACHT-1133: deleted partition_id from dataset/list restore #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ceeb3d1
YACHT-1133: deleted partition_id from dataset/list restore
marek-tabor Dec 4, 2018
456ebd3
YACHT-1133: deleted partition_id from dataset/list restore.
marek-tabor Dec 5, 2018
0388706
YACHT-1133: Restored + small fix of unit tests.
marek-tabor Dec 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/restore/dataset/dataset_restore_items_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ def generate_restore_items(cls, project_id, dataset_id, target_project_id,
target_project_id,
target_dataset_id,
table_entity.table_id,
table_entity.partition_id
)

restore_item = RestoreItem.create(source_table_reference,
Expand Down
3 changes: 1 addition & 2 deletions src/restore/list/backup_list_restore_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,5 +141,4 @@ def __create_target_table_reference(restore_request, source_entity):
target_dataset_id = source_entity.dataset_id
return TableReference(target_project_id,
target_dataset_id,
source_entity.table_id,
source_entity.partition_id)
source_entity.table_id)
3 changes: 1 addition & 2 deletions tests/restore/dataset/test_dataset_restore_items_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,7 @@ def __generate_expected_restore_item(
custom_target_dataset)
expected_target = TableReference(project_id=target_project_id,
dataset_id=target_dataset,
table_id=table.table_id,
partition_id=table.partition_id)
table_id=table.table_id)
expected_restore_item = RestoreItem.create(expected_source,
expected_target)
return expected_restore_item
Expand Down
2 changes: 0 additions & 2 deletions tests/restore/list/test_backup_list_restore_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ def test_that_restore_service_will_receive_suitable_request(
"target_project_id",
"target_dataset_id",
"source_table_id",
"source_partition_id"
)
expected_restore_item = RestoreItem.create(
expected_source_table_reference,
Expand Down Expand Up @@ -116,7 +115,6 @@ def test_that_restore_service_will_generate_default_values_if_missing(
"source_project_id",
"source_dataset_id",
"source_table_id",
"source_partition_id"
)
expected_restore_item = RestoreItem.create(
expected_source_table_reference, expected_target_table_reference
Expand Down