#351 Inline editable enchancements #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieTheBotDev
commented
Jan 5, 2017
| @@ -63,7 +63,7 @@ class InlineMorphSection extends MorphSection | |||
| morphSection.detector = undefined | |||
| morphSection.hide() | |||
| @on 'hide', 'hx.morph-section', (data) -> | |||
| exitEditMode.call(morphSection, data.toggle, data.content) | |||
| exitEditMode?.call(morphSection, data.toggle, data.content) | |||
There was a problem hiding this comment.
So you don't have to pass it through as an empty function if you don't have an exit edit mode function
| } | ||
|
|
||
| .hx-inline-editable-no-value { | ||
| font-style: italic; |
There was a problem hiding this comment.
Making it italic when no value has been entered is probably enough of a visual cue (along with the Enter Value text) that the user should do something
|
|
||
| value: (value) -> | ||
| if value isnt undefined | ||
| @textSelection.text(value) | ||
| @emit('change', {api: false, value: value}) | ||
| @emit('change', { cause: 'api', value: value }) |
There was a problem hiding this comment.
This was broken anyway (api was always passed as false) so I updated to the cause/value mentality.
jmsmyth
approved these changes
Jan 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
enterValueTextoption to display when no value is entered (see screenshots)valueoption (defaults toselection.text()as previous)changeevent - it was passing{api: false, value:<value>}regardless of whether the value was set with the api or by the user (now uses standardchange/valuedata)enterto set the valueMotivation and Context
The initial scope of this was to resolve #351 but in the process of resolving it and adding tests I noticed a few other bugs
How Has This Been Tested?
Added tests for full coverage of the module, tested on the demo page example
Screenshots (if appropriate):
Checklist: