Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocaml-migrate-parsetree.2.2.0+stock fails to compile with ocaml.5.00.0+trunk #262

Open
shubhamkumar13 opened this issue Nov 15, 2021 · 2 comments

Comments

@shubhamkumar13
Copy link
Contributor

OCaml.5.00.0+trunk doesn't work with the current ocaml-migrate-parsetree.2.2.0+stock and logs out the following error

#=== ERROR while compiling ocaml-migrate-parsetree.2.2.0+stock ================#
# context              2.0.10 | linux/x86_64 | ocaml-base-compiler.5.00.0+trunk | file:///drone/src/dependencies
# path                 /drone/src/_opam/5.00.0+trunk/.opam-switch/build/ocaml-migrate-parsetree.2.2.0+stock
# command              /drone/src/_opam/5.00.0+trunk/bin/dune build -p ocaml-migrate-parsetree -j 47
# exit-code            1
# env-file             /drone/src/_opam/log/ocaml-migrate-parsetree-29772-0d22b9.env
# output-file          /drone/src/_opam/log/ocaml-migrate-parsetree-29772-0d22b9.out
### output ###
#        ocaml src/ast-version (exit 1)
# (cd _build/default/src && /drone/src/_opam/5.00.0+trunk/bin/ocaml config/gen.ml 5.00.0+dev0-2021-11-05)
# Unknown OCaml version 5.00.0+dev0-2021-11-05

and since the current trunk's ast is not frozen it's best to wait for trunk to be frozen and then create a new ppxlib branch to work with OCaml.5.00.0+trunk in sandmark (since ocaml-migrate-parsetree is not needed for 5.0).

This would temporarily result in failure of a couple of irmin benchmarks

File "benchmarks/irmin/dune", line 4, characters 18-27:
	4 | 	(libraries irmin irmin.mem lwt lwt.unix))
	                      ^^^^^^^^^
	Error: Library "irmin.mem" not found.
	Hint: try:
	  dune external-lib-deps --missing --profile release --workspace ocaml-versions/.workspace.5.00.0+trunk @buildbench
File "benchmarks/irmin/dune", line 9, characters 118-123:
	9 | 	(libraries ppx_deriving_yojson.runtime irmin-pack irmin-pack.layered irmin-layers index fmt logs lwt lwt.unix yojson irmin unix cmdliner))
	                                                                                                                          ^^^^^
	Error: Library "irmin" not found.
	Hint: try:
	  dune external-lib-deps --missing --profile release --workspace ocaml-versions/.workspace.5.00.0+trunk @buildbench
	      ocamlc benchmarks/yojson/.ydump.eobjs/byte/dune__exe__Ydump.{cmi,cmo,cmt} [5.00.0+trunk_1]

Hence it seems best to currently track the benchmark failures in #261
and fix it when 5.0's AST is frozen.

@shubhamkumar13
Copy link
Contributor Author

shubhamkumar13 commented Nov 24, 2021

#261 also removes the run_in_ci tag from run_config.json to remove the irmin benchmarks.

When this issue is resolved please add the run_in_ci in the tags field

  1.     {
       "executable": "benchmarks/irmin/irmin_mem_rw.exe",
       "name": "irmin_mem_rw",
       "tags": [
         "1s_10s",
         "macro_bench"
       ],
       "runs": [
         {
           "params": "10_000 50_000 80 100_000_000"
         },
         {
           "params": "10_000 50_000 20 100_000_000"
         }
       ]
     },
  2.  {
       "executable": "benchmarks/irmin/layers.exe",
       "name": "irmin_pack_layered_1",
       "tags": [
         "gt_100s"
       ],
       "runs": [
         { "params": " -n 16000" }
       ]
     },
     {
       "executable": "benchmarks/irmin/layers.exe",
       "name": "irmin_pack_layered_2",
       "tags": [
         "gt_100s"
       ],
       "runs": [
         { "params": " -n 100 -b 100" }
       ]
     }

@Sudha247
Copy link
Contributor

OMP is no longer required for the trunk compatible ppxlib version: ppxlib.0.25.0~5.00preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants