Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmarks and domainslib to support ocaml 4.14.0+domains (ocaml 5.0) #261

Merged

Conversation

shubhamkumar13
Copy link
Contributor

This PR is the first step in adding ocaml 5.0 support for the benchmarks in sandmark.

The PR adds domainslib.0.3.2 and updates the benchmarks supporting the updated api for domainslib

@shakthimaan
Copy link
Contributor

# OCaml version mismatch: 5.00.0, expected 4.14.0

The version number mismatch is causing the 4.14.0+trunk build to fail. The following issue is related: ocaml-multicore/ocaml-multicore#709.

@kayceesrk
Copy link
Contributor

Looks like upstream has changed the version number to 5.00.0: https://github.com/ocaml/ocaml/blob/trunk/VERSION#L1. So 4.14.0+trunk should be 5.00.0+trunk.

@kayceesrk
Copy link
Contributor

Ping @shubhamkumar13.

@shubhamkumar13
Copy link
Contributor Author

shubhamkumar13 commented Nov 18, 2021

I've added an issue tracing irmin benchmarks failing on ocaml.5.00.0+trunk which would be fixed when the trunk is frozen (which would be easier for generating ppxlib version supporting trunk).

I think it's best to merge this before and then #257 can be merged (since there are changes to drome.yml file where I've updated the trunk from 4.14.0+trunk to 5.00.0+trunk)

@shubhamkumar13
Copy link
Contributor Author

This PR also updates drone.yml file to 5.00.
This is in addition to the adding the updated domainslib and making benchmarks compatible to 5.00

Makefile Show resolved Hide resolved
…ml-migrate-parsetree build is not attempted in OCaml.5.00.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants