Remove Base, Stdio orun dependency for trunk #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayceesrk
reviewed
Sep 9, 2020
| @@ -12,7 +12,7 @@ | |||
| (executable | |||
| (name orun) | |||
| (public_name orun) | |||
| (libraries base stdio re str cmdliner yojson unix wait4 profiler)) | |||
There was a problem hiding this comment.
Yes. Base.List, Base.Int and Base.String are used in orun.ml.
There was a problem hiding this comment.
@sadiqj Does it matter whether orun depends on base and stdio? Being an orun dependency shouldn't prevent us from building ocaml trunk in sandmark. I must be missing something.
There was a problem hiding this comment.
The need for Base has now been removed from the PR.
shakthimaan
changed the title
|
Just checking, are there any blockers to merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
orundependency forBaseandStdiois removed using this PR to facilitate building Sandmark with trunk.