Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split out multibench target in to serial and parallel #39

Closed
wants to merge 6 commits into from
Closed

split out multibench target in to serial and parallel #39

wants to merge 6 commits into from

Conversation

sadiqj
Copy link
Contributor

@sadiqj sadiqj commented Jul 18, 2019

No description provided.

@sadiqj sadiqj requested a review from ctk21 July 18, 2019 15:00
ctk21
ctk21 approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@ctk21 ctk21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Small nit for the CI, can we put the 4.08 run at the back after the multicore runs? Given how long things take to run, if the parallel or multibench stuff fails, then it will happen before the 4.08 kicks off.

@ctk21 ctk21 force-pushed the split_multibench_serial_parallel branch from 434dfc6 to b3c8624 Compare July 25, 2019 12:59
@ctk21 ctk21 mentioned this pull request Oct 3, 2019
Closed
@ctk21
Copy link
Member

ctk21 commented Oct 3, 2019

something bad with the CI here, but we want to drop this to progress #54
we are tracking it as an issue #58

@ctk21 ctk21 closed this Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctk21 ctk21 ctk21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sadiqj @ctk21