Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dependency to Unix #1

Closed
samoht opened this issue Feb 26, 2015 · 9 comments
Closed

Remove the dependency to Unix #1

samoht opened this issue Feb 26, 2015 · 9 comments
Labels

Comments

@samoht
Copy link

samoht commented Feb 26, 2015

That would be great to not depend on Unix at all!

@sagotch
Copy link
Collaborator

sagotch commented Feb 26, 2015

Copying and pasting unix time functions (or part of) you need?

I could look at it when I will be back from holiday.

@c-cube
Copy link
Member

c-cube commented Apr 10, 2018

I think this can be closed?

@sagotch
Copy link
Collaborator

sagotch commented Apr 11, 2018

This issue has not been resolved, but I do not plan to work on it.

@c-cube
Copy link
Member

c-cube commented Jun 18, 2018

What are the unix functions used for? I can try to take a look at it (maybe indeed by copying and adapting some code) if it's still a desirable feature.

@sagotch
Copy link
Collaborator

sagotch commented Jun 18, 2018

The library itself relies on Unix.gmtime to handle day/month/year fields.

@c-cube
Copy link
Member

c-cube commented Jun 18, 2018

Ah, it seems gmtime is a thin wrapper around the underlying C API… So I guess that to get a pure OCaml solution right would be a lot of work 😞

@sagotch
Copy link
Collaborator

sagotch commented Jun 19, 2018

I think so. But do you know a platform where Unix module would not be supported? ISO8601 could use its own type and wrapper to C call, but I do not see the point...

On the other hand, going from a float/tm to a tm/float from scratch is probably just copy/pasting/translating some well-known algorithm, so it should not be that hard to do, but you need time to do it ^^

@c-cube
Copy link
Member

c-cube commented Jun 19, 2018

I'm not sure, are there stubs for that in jsoo? Not that jsoo matters to me, but I don't really consider unix as universally available.

@c-cube c-cube added the wontfix label Sep 12, 2019
@c-cube
Copy link
Member

c-cube commented Sep 12, 2019

Until a clean solution is found, or someone makes a PR for that, I'm closing it.

@c-cube c-cube closed this as completed Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants