Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added full guard pattern error #220

Merged
merged 2 commits into from
Jun 3, 2022
Merged

Added full guard pattern error #220

merged 2 commits into from
Jun 3, 2022

Conversation

paulpatault
Copy link
Contributor

Add specific error message for patterns with guard on every clause.

@paulpatault paulpatault force-pushed the full-when-error branch 2 times, most recently from 45434e4 to 424a0ff Compare June 2, 2022 15:40
pascutto
pascutto requested changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@pascutto pascutto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a very minor fix :)

src/warnings.ml Outdated Show resolved Hide resolved
pascutto
pascutto approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@pascutto pascutto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pascutto pascutto merged commit bf943de into ocaml-gospel:main Jun 3, 2022
@paulpatault paulpatault deleted the full-when-error branch June 3, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascutto pascutto pascutto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulpatault @pascutto