Check for out of scope variables. #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-osborne
force-pushed
the
fix-out-of-scope
branch
5 times, most recently
from
0f6de4c
to
dd8d324
Compare
shym
approved these changes
Nov 9, 2023
Returned values are out of scope in this function. The error message will not be printed to the user as we forget about why we counldn't use a term when looking for one suitable for `next_state`. (See the use of `to_option` in `next_state_case`)
Fixes ocaml-gospel#171 Non compiling code is not generated anymore, but the user doesn't know why `next_state` was not generated.
n-osborne
force-pushed
the
fix-out-of-scope
branch
from
dd8d324
to
cc86d61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171
This PR proposes to check for out of scope variables (returned values when building
next_statefunction) in thesubst_termfunction.It can be argued that
subst_termis now doing a lot of different things, but the added feature does not add lot of complexity, I used an optional arguement so that the change is transparent for user that does not need the new feature, and writing another function implementing this check would necessitate the same traversal of the term type.Non compiling code is not generated anymore, but if the
next_statefunction has not been generated, the user stay unaware of the why.I didn't fix this last problem in this PR because it may necessitate a larger reflexion on which errors we want to display and which errors we want to forget about.