Buf_write.create: make switch optional #283
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The switch is useful to ensure that any fibers waiting for a flush are cancelled on error. However, it's not essential, and whatever cancelled the writer will probably cancel the flushing fibers too anyway. This makes it easier to create buffers outside of the eio event loop and is useful when porting existing code from Faraday.
Also, expose the
abort
function and theFlush_aborted
exception, so that callers can clean up manually.