Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eio.Net: add getnameinfo #288

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Conversation

bikallem
Copy link
Contributor

No description provided.

@bikallem bikallem force-pushed the getnameinfo branch 3 times, most recently from deee28d to 46baa6a Compare August 22, 2022 18:27
@bikallem bikallem requested a review from talex5 August 23, 2022 09:01
lib_eio/net.mli Outdated Show resolved Hide resolved
lib_eio_linux/eio_linux.ml Outdated Show resolved Hide resolved
@bikallem bikallem force-pushed the getnameinfo branch 2 times, most recently from 104f379 to 400b51f Compare August 24, 2022 10:17
@bikallem
Copy link
Contributor Author

@talex5 I have removed ni_dgram from the API. Since luv doesn't support getnameinfo on UNIX domain, we now use Eio_unix.getnameinfo on both uring and luv backends.

Copy link
Collaborator

@talex5 talex5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

@talex5 talex5 merged commit 0984588 into ocaml-multicore:main Aug 25, 2022
@bikallem bikallem deleted the getnameinfo branch August 25, 2022 09:10
talex5 added a commit to talex5/opam-repository that referenced this pull request Aug 26, 2022
CHANGES:

New features:

- Add `Eio.Condition` (@TheLortex @talex5 ocaml-multicore/eio#277).
  Allows a fiber to wait for some condition to become true.

- Add `Eio.Net.getaddrinfo` and `getnameinfo` (@bikallem @talex5 ocaml-multicore/eio#278 ocaml-multicore/eio#288 ocaml-multicore/eio#291).
  Convert between host names and addresses.

- Add `Eio.Debug` (@talex5 ocaml-multicore/eio#276).
  Currently, this allows overriding the `traceln` function.

- `Buf_write.create`: make switch optional (@talex5 ocaml-multicore/eio#283).
  This makes things easier for people porting code from Faraday.

Bug fixes:

- Allow sharing of libuv poll handles (@patricoferris @talex5 ocaml-multicore/eio#279).
  Luv doesn't allow two callers to watch the same file handle, so we need to handle that in Eio.

Other changes:

- Upgrade to uring 0.4 (@talex5 ocaml-multicore/eio#290).

- Mention `Mutex`, `Semaphore` and `Condition` in the README (@talex5 ocaml-multicore/eio#281).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants