Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCaml 4.13 compatibility #340

Merged
merged 1 commit into from
May 3, 2023
Merged

OCaml 4.13 compatibility #340

merged 1 commit into from
May 3, 2023

Conversation

psafont
Copy link
Contributor

@psafont psafont commented May 2, 2023 •
edited

This is the change mentioned in #329 (comment)

I've added a workflow to make sure the compatibility doesn't get broken, let me know if this is inconvenient for you.

I've opened the PR rather than waiting for edwin to come back because with the current situation, the patch is needed in order to make CI pass for xapi-project/xen-api#4985 so I'd rather get the compatibility merged sooner rather than later

@psafont psafont force-pushed the ocaml4.13 branch 2 times, most recently from 5e7fab7 to 2fb7dc1 Compare May 2, 2023 12:56
@jmid
Copy link
Collaborator

jmid commented May 2, 2023

PR looks good - many thanks! 😃

For the workflow, I was just merging #339 last night that includes a CI workflow update for 4.14 to .github/workflows/opam.yml. A rebase on main and adding 4.13 there would be preferable, I think.
For now, that workflow runs once a week, but it would be fine to increase the interval or change it to per-push, since there will now be multiple versions to check.

@psafont
Copy link
Contributor Author

psafont commented May 2, 2023

Will change the workflow, then, it'll be less trouble

@edwintorok @psafont
OCaml 4.13 compatibility
2b6cc0f 
Co-authored-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
@psafont
Copy link
Contributor Author

psafont commented May 2, 2023

Should be good to go now

jmid
jmid approved these changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@jmid jmid left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!
I'll let the CI run and then merge later today.

jmid added a commit that referenced this pull request May 3, 2023
@jmid
Merge pull request #340 from psafont/ocaml4.13
c076d0d
@jmid jmid merged commit 2b6cc0f into ocaml-multicore:main May 3, 2023
15 of 18 checks passed
@psafont psafont deleted the ocaml4.13 branch May 3, 2023 09:02
jmid added a commit that referenced this pull request May 15, 2023
@jmid @psafont @edwintorok
Write out Seq.equal to support 4.13
7399887 
Avoid using Seq.equal which was added in 4.14.
Initially fixed in #340 and then broken in #342.

Co-authored-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Co-authored-by: Edwin Török <edwin.torok@cloud.com>
jmid added a commit that referenced this pull request May 15, 2023
@jmid @psafont @edwintorok
Write out Seq.equal to support 4.13
bf65c3f 
Avoid using Seq.equal which was added in 4.14.
Initially fixed in #340 and then broken in #342.

Co-authored-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Co-authored-by: Edwin Török <edwin.torok@cloud.com>
@jmid jmid mentioned this pull request May 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmid jmid jmid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@psafont @jmid @edwintorok