Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opam installation updates #346

Merged
merged 3 commits into from
May 15, 2023
Merged

Opam installation updates #346

merged 3 commits into from
May 15, 2023

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented May 15, 2023

This fixes #345

When checking to see whether the ppx avoiding in #342 would fix the failing opam install from #345, I discovered that the #342's refactoring actually broke the 4.13 support just added in #340...

This PR thus

The install workflows are quite fast, so I favor protecting against such breakage again now that we actually support 4.13 and 4.14.

jmid and others added 3 commits May 15, 2023 11:59
Avoid using Seq.equal which was added in 4.14.
Initially fixed in #340 and then broken in #342.

Co-authored-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Co-authored-by: Edwin Török <edwin.torok@cloud.com>
@jmid
Copy link
Collaborator Author

jmid commented May 15, 2023

CI summary:

  • The 32 bits test are failing as noted in 32-bit pre-setup fails #344
  • A macOS 5.1 STM int64 ref test parallel asymmetric failed to trigger
  • Cygwin tests are still ongoing (2 of them completed part 1 successfully at this point)

In the interest of restoring 4.13 support I'll therefore merge the PR.

@jmid jmid merged commit 098e2c3 into main May 15, 2023
@jmid jmid deleted the opam-install-5.1-experiment branch May 15, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opam workflow fails on 5.1
1 participant