Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: renaming Lin Internal tests #396

Merged
merged 9 commits into from
Sep 20, 2023
Merged

Chore: renaming Lin Internal tests #396

merged 9 commits into from
Sep 20, 2023

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Sep 12, 2023

This PR cleans up a bit of historical bagage:
Lin.Internal was once known as Lin and lin_tests.ml-files named accordingly.
We thus rename these to lin_internal_tests.ml and adjust their test titles accordingly.
The latter should help separate one from the other in the CI logs (I for one, have confused myself over this).

Overall. the PR should however not change the functionality of the test suite.

@jmid
Copy link
Collaborator Author

jmid commented Sep 13, 2023

CI summary for cb27759

Of the 27 completed runs 5 failed: 2 failures were genuine, 1 was a false alarm, and 2 are caching related

@jmid
Copy link
Collaborator Author

jmid commented Sep 20, 2023

CI summary for c332d03

Of the 56 completed runs 5 failed: 1 failures was genuine, 1 was a false alarm, and 3 due to CI-caching.
I'll merge.

@jmid jmid merged commit abdb794 into main Sep 20, 2023
48 of 51 checks passed
@jmid jmid deleted the lin-renaming branch September 20, 2023 12:09
@jmid
Copy link
Collaborator Author

jmid commented Sep 21, 2023

CI summary for the merge into main:

Of the 37 completed runs 9 failed: 5 were opam failures, 3 failures was genuine, 1 is in the gray zone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant