Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Lin DSL test renaming #408

Merged
merged 23 commits into from
Nov 8, 2023
Merged

Chore: Lin DSL test renaming #408

merged 23 commits into from
Nov 8, 2023

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Nov 7, 2023

This PR is the sister PR to #396, eliminating historical occurrences of DSL and dsl in file and test names.
Together, the effect of the two PRs is the following renaming:

lin_tests.ml      --> lin_internal_tests.ml      # for Lin_internal tests
lin_tests_dsl.ml  --> lin_tests.ml               # for Lin tests

The DSL name is historic and was eliminated before our initial opam package release.
As Lin is the primary user-facing library for sequential consistency testing, I think this is preferable.
It should be more intuitive to locate the right test with these names.

If done right, the PR should have no effect on test suite functionality... (I'm already seeing lots of weird red CI lights though! 馃槵 )

While at it, I also spotted a few tests that were missing from the overview in src/README.md.

@jmid
Copy link
Collaborator Author

jmid commented Nov 7, 2023

I just restarted a bunch of jobs as roughly 1/2 of the GitHub actions workflows failed after seconds, due to some internal glitch I suppose. The restarted runs seem to progress fine though.

@jmid
Copy link
Collaborator Author

jmid commented Nov 8, 2023

CI summary:

Out of 63 workflows (incl. 10 opam install ones) 5 failed, of which 4 were genuine and 1 was a borderline case

@jmid jmid merged commit 71e9142 into main Nov 8, 2023
48 of 53 checks passed
@jmid jmid deleted the lin-dsl-renaming branch November 8, 2023 08:44
@jmid
Copy link
Collaborator Author

jmid commented Nov 8, 2023

CI summary for merge to main:

Out of 38 workflows, 1 failed - with a genuine failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant