Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend STM Array tests #414

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Extend STM Array tests #414

merged 4 commits into from
Nov 17, 2023

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Nov 17, 2023

I started going over our existing tests, and discovered a couple of Array entries which could easily be targeted with STM:

  • for_all
  • exists
  • find_opt
  • find_index
  • stable_sort
  • fast_sort

Afterwards, when the 5.0 CI workflows couldn't compile, I realized that Array.find_index was a recent 5.1 addition.
For now, this PR therefore leaves it commented out, and so leaves us extending with 5/6 of the above.

Handling an entry conditionally will require some machinery and potentially add additional dependencies.
I don't think it is warranted to do so ATM just to target find_index... 🤷

@jmid
Copy link
Collaborator Author

jmid commented Nov 17, 2023

CI summary:

Out of 63 workflows 1 failed - a false alarm

@jmid jmid merged commit d6ebdaf into main Nov 17, 2023
52 of 53 checks passed
@jmid jmid deleted the stm-array-extend branch November 17, 2023 22:56
@jmid
Copy link
Collaborator Author

jmid commented Nov 19, 2023

CI summary for merge to main

Out of 38 workflows 1 failed with a false alarm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant