Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable Bigarray STM tests #452

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Reenable Bigarray STM tests #452

merged 4 commits into from
Apr 18, 2024

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Apr 17, 2024

This PR reenables the Bigarray STM tests, the idea being that a model-based STM test is stricter than a Lin one.

A bit of background:

@jmid
Copy link
Collaborator Author

jmid commented Apr 18, 2024

The two 32-bit runs are failing since size_in_bytes return 4b * 16 = 64b and breaks with the 8b word assumption hardcoded in the mode. I guess #250 predates us testing 32-bit... 🤷

On macOS 5.2 and MSVC bytecode the parallel STM Bigarray tests failed to trigger a counterexample within 1000 iterations. The old Lin test had a count of 5000 for this reason.

CI summary for 4713ced:

@jmid
Copy link
Collaborator Author

jmid commented Apr 18, 2024

Rebased on main after the merge of #453 to remove noise.

  • a3f7202 should take care of the 32 failures
  • e9421bb should take care of the failures to trigger a counterexample within 1000 iterations

@jmid
Copy link
Collaborator Author

jmid commented Apr 18, 2024

CI summary:

This one was missed in #453 - #454 addresses the omission

Out of 37 workflows 1 failed with a genuine issue

@jmid jmid merged commit 73033b7 into main Apr 18, 2024
26 of 27 checks passed
@jmid jmid deleted the bigarray-stm-tests branch April 18, 2024 20:07
@jmid
Copy link
Collaborator Author

jmid commented Apr 19, 2024

CI summary for merge to main:

Out of 38 workflows 1 failed with a genuine issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant