Segmentation fault when assigning function to reference in different thread

[radekm]

The following program

effect Yield : unit

let () =
  let kk = ref (fun () -> failwith "continuation") in
  begin match
    print_endline "0";
    perform Yield;
    print_endline "1";
    Unix.sleep 1;
    perform Yield;
    print_endline "2"
  with
    | () -> print_endline "done"
    | effect Yield k ->
        print_endline "before kk assig";
        kk := (fun () -> continue k ());
        print_endline "after kk assig"
  end;
  print_endline "before spawn";
  Domain.spawn (fun () -> !kk ());
  print_endline "after spawn";
  Unix.sleep 20;
  print_endline "after sleep"

always ends with segmentation fault. The output is usually

0
before kk assig
after kk assig
before spawn
1
after spawn
before kk assig
Segmentation fault

It seems that the problem occurs when performing Yield after Unix.sleep 1. What helps is replacing Domain.spawn (fun () -> !kk ()) by !kk ().

[radekm]

The segmentation fault happens when assigning to kk - when executing kk := (fun () -> continue k ()). Even when I assign value which doesn't contain k(eg. (fun () -> ())) there is still segmentation fault:

effect Yield : unit

let () =
  let kk = ref (fun () -> failwith "continuation") in
  let assig_k = ref true in
  begin match
    print_endline "0";
    perform Yield;
    print_endline "1";
    Unix.sleep 1;
    perform Yield;
    print_endline "2"
  with
    | () -> print_endline "done"
    | effect Yield k ->
        print_endline "before kk assig";
        if !assig_k then begin
          assig_k := false;
          print_endline "assigning k";
          kk := (fun () -> continue k ())
        end else begin
          print_endline "not assigning k";
          kk := (fun () -> ())
        end;
        print_endline "after kk assig"
  end;
  print_endline "before spawn";
  Domain.spawn (fun () -> !kk ());
  print_endline "after spawn";
  Unix.sleep 20;
  print_endline "after sleep"

[kayceesrk]

Fixed by #14.