Fix stack promotion. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a part of promoting the stack, objects pointed to by the stack should also be promoted. This commit fixes a bug that ignores the latter if the stack is on a minor heap. The fix always scans the stack, and also marks it clean since the stack no longer points to a minor heap. The unconditional stack scanning can be optimized by only scanning the stack if the stack is in the minor heap or in the major heap and is marked as dirty.
|
Also, this fixes #13. |
sadiqj
pushed a commit
to sadiqj/ocaml-multicore
that referenced
this pull request
Feb 13, 2020
Stw plus safepoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of promoting the stack, objects pointed to by the stack should also be promoted. This commit fixes a bug that ignores the latter if the stack is on a minor heap;
caml_scan_dirty_stackonly scans dirty stack whereas stacks in a minor heap are never marked as dirty. The fix always scans the stack, and also marks it clean since the stack no longer points to a minor heap.The unconditional stack scanning can be optimized by only scanning the stack if the stack is in the minor heap or in the major heap and is marked as dirty.