Parallel minor gc inline mask rework #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der_t for get_header_val inline get_header_val and make spin_on_header a slow path
sadiqj
approved these changes
Jun 19, 2020
|
Here is bench run output with #359 and this PR combined [orange] vs 4.10.0+multicore [blue] with a 4.10.0+stock baseline. |
|
Nice improvements! |
sadiqj
pushed a commit
to sadiqj/ocaml
that referenced
this pull request
Jan 10, 2022
…21/parallel_minor_gc_inline_mask_rework Parallel minor gc inline mask rework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the promotion path of the parallel_minor_gc. Couple of things:
get_header_valfunction and gives the externally visible non-inline function thecaml_prefixcpu_relaxif we end up spinning on the headerThese changes in addition to #359 are giving 3-5% improvements on
test_decompresssandmark benchmark which does a lot of minor collections. It is giving an executed instruction decrease across all benchmarks even if a significant change of performance is harder to see on less minor collection heavy benchmarks.