otherlibs: remove caml_channel_mutex_io hooks from systhreads #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, merging |
sadiqj
pushed a commit
to sadiqj/ocaml
that referenced
this pull request
Jan 10, 2022
…ove_old_mutex_io_hooks otherlibs: remove caml_channel_mutex_io hooks from systhreads
ctk21
added a commit
to ctk21/ocaml
that referenced
this pull request
Jan 11, 2022
…ove_old_mutex_io_hooks otherlibs: remove caml_channel_mutex_io hooks from systhreads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
caml_channel_mutex_iohooks in systhreads.The rationale is that this behavior is now the default behavior in Multicore-OCaml as of #649, and the relevant thread local values are kept thread local in our implementation (rather than domain-local), which means it behaves the same as systhreads.