Clarify documentation of Lazy wrt. RacyLazy and Undefined exceptions #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove ambiguous thread-safety claim - Clarify raising behaviour of try_force - Clarify unsafety before 5.0 (Related to discussion at ocaml-multicore#520)
|
LGTM. Thanks! Separately, it may be useful to provide force_spin_wait which always returns a value, with "spin_wait" hopefully making the semantics clear? |
sadiqj
pushed a commit
to sadiqj/ocaml
that referenced
this pull request
Jan 10, 2022
…rify_try_force
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kayceesrk Following discussion at #520. From the commit log:
try_forceWith this clarification done, the asymmetry of
try_forceregarding race conditions appears clearly. I can also look into returning a value in every case and never raise if that's obviously better. (But as mentioned in the discussion above, it will not help the use-case I had in mind.)