Finish off tools/check-typo on the repo #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are correct @dra27. |
|
Many thanks for these cleanups, appreciated. LGTM, merging! |
sadiqj
pushed a commit
to sadiqj/ocaml
that referenced
this pull request
Jan 10, 2022
…ck-typo Finish off tools/check-typo on the repo
ctk21
added a commit
to ctk21/ocaml
that referenced
this pull request
Jan 11, 2022
…ck-typo Finish off tools/check-typo on the repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be checked commit-by-commit and the last commit can be ignored (or patdiff can be used to limit its noise).
Two things remain:
tools/eventlog_to_latencies.pyandtools/gdb_ocamlrun.pystill contain over-long linesFIXMEcomments of @kayceesrk's inruntime/caml/stack.hwhich I figured might want removing, rather than line-breaking?