Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Dropped comment in some cinaps code. #2468

Closed
tdelvecchio-jsc opened this issue Oct 25, 2023 · 2 comments
Closed

Bug: Dropped comment in some cinaps code. #2468

tdelvecchio-jsc opened this issue Oct 25, 2023 · 2 comments
Labels
Kind/Bug ❌

Comments

@tdelvecchio-jsc
Copy link
Contributor

Describe the bug
The following test causes ocamlformat to exit with code 1, and an error about a comment being changed:

(*$
  let _ =
    [ x (*
      *)
    ; y
    ]
  ;;
*)

ocamlformat version: 181da77 (ocaml-ppx/main as of post creation)
command: dune exec bin/ocamlformat/main.exe -- example.ml
@Julow
Copy link
Collaborator

Julow commented Oct 26, 2023

This is fixed by #2371

@Julow Julow mentioned this issue Oct 26, 2023
Merged
Julow added a commit to Julow/ocamlformat that referenced this issue Oct 26, 2023
@Julow
Add testcase for ocaml-ppx#2468
8f3d799
@tdelvecchio-jsc tdelvecchio-jsc mentioned this issue Nov 2, 2023
Closed
@Julow
Copy link
Collaborator

Julow commented Nov 8, 2023

This is fixed by #2371 and a test case have been added.

@Julow Julow closed this as completed Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Kind/Bug ❌
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug multiline comment in cinaps tdelvecchio-jsc/ocamlformat
2 participants
@Julow @tdelvecchio-jsc