New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert doc-comments change to the default profile #1335
Conversation
Why does it change the formatting of vendored code? appart that LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks
CHANGES.md
Outdated
#### Changes | ||
|
||
+ The default for `doc-comments` is changed to `after` (#1335) (Jules Aguillon) | ||
This revert a change introduced in 0.14.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you mention #1325 here so we can easily jump back and forth between the PRs ? thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change is from #1012. The change to the ocamlformat
profile is not reverted by this PR.
That's because the vendored code uses the |
We should probably disable formatting of vendored code. This makes using |
I was not aware of that, sure we can disable it. |
This surprised users.
95957b5
to
60bfa19
Compare
CHANGES: #### Changes + The default for `doc-comments` is changed to `after` (ocaml-ppx/ocamlformat#1335) (Jules Aguillon) This reverts a change introduced in 0.14.0 (ocaml-ppx/ocamlformat#1012). + Revert deprecation of the `doc-comments` option (ocaml-ppx/ocamlformat#1331) (Jules Aguillon) This reverts a change introduced in 0.14.0 (ocaml-ppx/ocamlformat#1293).
This surprised users.
We should release 0.14.1 with this patch.
cc @samoht