Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Indent] use ocp-indent when ocamlformat is deactivated #1811

Closed
wants to merge 1 commit into from

Conversation

bobot
Copy link
Contributor

@bobot bobot commented Sep 17, 2021

Fixes #1792 . If ocamlformat is disable directly use ocp-indent for indentation instead of still trying to parse it.

But no tests have been added.

@bobot
Copy link
Contributor Author

bobot commented Sep 22, 2021

@gpetiot #1814 could make this PR obsolete, but it could still be useful for outputting better information in disabled case.

@gpetiot
Copy link
Collaborator

gpetiot commented Sep 23, 2021

I think the numeric feature should never be called in emacs if ocamlformat is disabled.
Maybe ocamlformat will be the entry point for ocp-indent in the future but I'm not sure that's where we want to go, so I'm not fond of calling ocp-indent when ocamlformat is disabled.

I'm closing this one for now :)

@gpetiot gpetiot closed this Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: In emacs, indentation in project where ocamlformat is not activated
3 participants